Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Java basics examples #132

Merged
merged 7 commits into from
May 2, 2024
Merged

Add Java basics examples #132

merged 7 commits into from
May 2, 2024

Conversation

gvdongen
Copy link
Collaborator

@gvdongen gvdongen commented Apr 30, 2024 •
edited
Loading

  • Adding the Java equivalent of the TypeScript basics

Skipping workflows for now, until we officially release them.

@gvdongen gvdongen requested a review from igalshilman April 30, 2024 08:25
igalshilman
igalshilman approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@igalshilman igalshilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! thanks for creating the java examples.
fyi I haven't run them locally tho, just went over the diff

basics/basics-java/src/main/java/utils/ExampleStubs.java Outdated
/*
* Copyright (c) 2024 - Restate Software, Inc., Restate GmbH
*
* This file is part of the Restate Examples for the Node.js/TypeScript SDK,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe it shouldn't say here typescript, but rather java

@gvdongen gvdongen merged commit e529893 into main May 2, 2024
2 checks passed
@gvdongen gvdongen deleted the java_basics branch May 2, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igalshilman igalshilman igalshilman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gvdongen @igalshilman