Skip to content

Commit

Permalink
Delete .npmrc, create it on the fly in CI (#29)
Browse files Browse the repository at this point in the history
* Delete .npmrc, create it on the fly in CI

For local development we assume that npm is already properly configured.
Removing the bundled dot file avoids overriding personal configurations.

* Apply suggestions from code review

---------

Co-authored-by: Jack Kleeman <[email protected]>
  • Loading branch information
pcholakov and jackkleeman authored Oct 3, 2023
1 parent 28dd4b7 commit df0c2e6
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
4 changes: 4 additions & 0 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,10 @@ jobs:
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}
- name: Create .npmrc
run: |
echo '@restatedev:registry=https://npm.pkg.github.com/' > typescript/.npmrc
echo '//npm.pkg.github.com/:_authToken=${GH_PACKAGE_READ_ACCESS_TOKEN}' >> typescript/.npmrc
- run: npm ci --prefix typescript
env:
GH_PACKAGE_READ_ACCESS_TOKEN: ${{ secrets.GH_PACKAGE_READ_ACCESS_TOKEN }}
Expand Down
2 changes: 0 additions & 2 deletions typescript/.npmrc

This file was deleted.

0 comments on commit df0c2e6

Please sign in to comment.