-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tour of Restate: Add Java SDK examples #202
Conversation
Deploying with Cloudflare Pages
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for creating this PR @pcholakov and @gvdongen. Your changes look good to me. I had a few minor comments which we should resolve before merging.
docusaurus.config.js
Outdated
// TODO: adding "java" breaks compilation of /references/admin-api.mdx for some reason?!? | ||
additionalLanguages: ["protobuf", "log"/*, "java"*/], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uncommenting java
does not break the build for me. It renders the Java code properly on my machine. Maybe this is a local env problem of yours?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's great news! I'll investigate what could be different. Something I noticed is that I had the latest yarn, but we seem to be using 1.22.21 in GitHub. Some dependency problems went away by switching to that.
This is what is being used on GitHub Actions at the moment anyway, according to setup-node logs.
Co-authored-by: Till Rohrmann <[email protected]>
Co-authored-by: Till Rohrmann <[email protected]>
Co-authored-by: Pavel Tcholakov <[email protected]>
Co-authored-by: Pavel Tcholakov <[email protected]>
Co-authored-by: Pavel Tcholakov <[email protected]>
Should now be complete across all the examples:
Open issues:
Java syntax highlighting causes my build to fail with:
I can try to upgrade Docusaurus to v3 to see if it helps; I made a quick attempt and it resulted in many, many other errors. May be more desirable to push this out as is, and fix that after the fact.