Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tour of Restate: Add Java SDK examples #202

Merged
merged 33 commits into from
Dec 13, 2023
Merged

Tour of Restate: Add Java SDK examples #202

merged 33 commits into from
Dec 13, 2023

Conversation

pcholakov
Copy link
Contributor

@pcholakov pcholakov commented Dec 6, 2023

Should now be complete across all the examples:

  • refreshed all Java code from tour repo
  • added output logs from manual test runs
  • lots of text cleanups for grammar, readability and general flow

Open issues:

  • Update the Git repository path / branch of the Java tour final location -- need to incorporate the changes from Add Java tour examples tour-of-restate#12 into tour-of-restate-typescript or another repo
  • Can we fix the MDX issue breaking the site build with Java syntax highlighting enabled?

Java syntax highlighting causes my build to fail with:

✖ Server
  Compiled with some errors in 17.33s

Browserslist: caniuse-lite is outdated. Please run:
  npx update-browserslist-db@latest
  Why you should do it regularly: https://github.com/browserslist/update-db#readme
Component Tabs was not imported, exported, or provided by MDXProvider as global scope
Component TabItem was not imported, exported, or provided by MDXProvider as global scope
Component TabItem was not imported, exported, or provided by MDXProvider as global scope
[ERROR] Docusaurus server-side rendering could not render static page with path /references/admin-api.


TypeError: Cannot set properties of undefined (setting 'triple-quoted-string')
[ERROR] Unable to build website for locale en.
[ERROR] Error: Failed to compile with errors.
    at /Users/pavel/restate/documentation/node_modules/@docusaurus/core/lib/webpack/utils.js:180:24
    at /Users/pavel/restate/documentation/node_modules/webpack/lib/MultiCompiler.js:554:14
    at processQueueWorker (/Users/pavel/restate/documentation/node_modules/webpack/lib/MultiCompiler.js:491:6)
    at process.processTicksAndRejections (node:internal/process/task_queues:77:11)
[INFO] Docusaurus version: 2.4.0
Node version: v18.17.1
error Command failed with exit code 1.

I can try to upgrade Docusaurus to v3 to see if it helps; I made a quick attempt and it resulted in many, many other errors. May be more desirable to push this out as is, and fix that after the fact.

Copy link

cloudflare-workers-and-pages bot commented Dec 6, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: f6c81dc
Status: ✅  Deploy successful!
Preview URL: https://8d602d70.documentation-beg.pages.dev
Branch Preview URL: https://tour-java.documentation-beg.pages.dev

View logs

@pcholakov pcholakov marked this pull request as ready for review December 8, 2023 17:57
Copy link
Contributor

@tillrohrmann tillrohrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating this PR @pcholakov and @gvdongen. Your changes look good to me. I had a few minor comments which we should resolve before merging.

Comment on lines 152 to 153
// TODO: adding "java" breaks compilation of /references/admin-api.mdx for some reason?!?
additionalLanguages: ["protobuf", "log"/*, "java"*/],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uncommenting java does not break the build for me. It renders the Java code properly on my machine. Maybe this is a local env problem of yours?

Copy link
Contributor Author

@pcholakov pcholakov Dec 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's great news! I'll investigate what could be different. Something I noticed is that I had the latest yarn, but we seem to be using 1.22.21 in GitHub. Some dependency problems went away by switching to that.

restate.config.json Outdated Show resolved Hide resolved
restate.config.json Outdated Show resolved Hide resolved
docs/tour.mdx Show resolved Hide resolved
docs/tour.mdx Show resolved Hide resolved
docs/tour.mdx Outdated Show resolved Hide resolved
docs/tour.mdx Outdated Show resolved Hide resolved
docs/tour.mdx Outdated Show resolved Hide resolved
docs/tour.mdx Outdated Show resolved Hide resolved
docs/tour.mdx Outdated Show resolved Hide resolved
This is what is being used on GitHub Actions at the moment anyway, according to setup-node logs.
@pcholakov pcholakov assigned pcholakov and gvdongen and unassigned pcholakov Dec 11, 2023
@gvdongen gvdongen merged commit fa8a8aa into main Dec 13, 2023
3 checks passed
@gvdongen gvdongen deleted the tour_java branch December 14, 2023 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants