Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatize submodule PR if framework name matches with submodules #250

Open
juanangp opened this issue Jun 14, 2022 · 7 comments · May be fixed by #259 or rest-for-physics/rawlib#71
Open

Automatize submodule PR if framework name matches with submodules #250

juanangp opened this issue Jun 14, 2022 · 7 comments · May be fixed by #259 or rest-for-physics/rawlib#71
Assignees

Comments

@juanangp
Copy link
Member

juanangp commented Jun 14, 2022

Recently we faced some issues when a submodule PR is merged while the required PR in framework is not merged. This issue can be addressed by automatizing the PR in framework when a branch of the same name is present in any submodule. This in principle can be done with a dependantbot https://docs.github.com/en/code-security/dependabot/working-with-dependabot/automating-dependabot-with-github-actions. We need the following requirements:

  • A PR in framework should trigger any submodule PR with a matching branch name.
  • As soon as the PR is merged in framework the different submodule PR should be also merged.
  • A stand-alone development in any submodule should not trigger any action in framework
  • A PR inside a submodule which matches any framework branch should not be allowed.
@juanangp
Copy link
Member Author

I need to create a personal access token to be capable to perform the PR in a different repo inside rest-for-physics. And I would prefer not to use my personal access token. Do you think is a good idea to create a rest-for-physics account (mail) from which we can create the personal access token? @jgalan and @lobis let me know what do you think.

@jgalan
Copy link
Member

jgalan commented Jun 30, 2022

Yes, I believe we already have one email account for rest-for-physics at google. I let you know via slack.

@juanangp
Copy link
Member Author

Thanks, a personal access token has been created with this account and have been added to secrets.

Note that this account has been added to the owners of the github rest-for-physics repo.

@juanangp
Copy link
Member Author

Note that this account has been added to the owners of the github rest-for-physics repo.

Now has been downgraded to member with some privileges since ownership was not needed. However, if you want to centralize ownership for rest-for-physics we can set this account as owner.

@jgalan
Copy link
Member

jgalan commented Jul 1, 2022

If you go to https://analytics.google.com using that account you may check the user activity at https://sultan.unizar.es/rest/ and at https://rest-for-physics.github.io

@jgalan
Copy link
Member

jgalan commented Jul 1, 2022

This year activity at https://rest-for-physics.gihub.io since January

Screenshot 2022-07-01 at 12 31 31

Screenshot 2022-07-01 at 12 32 05

@jgalan
Copy link
Member

jgalan commented Jul 1, 2022

April is the publication @nkx111

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants