Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New workflow frameworkPR for automatic submodule PR merging #259

Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open

New workflow frameworkPR for automatic submodule PR merging #259

wants to merge 21 commits into from

Conversation

juanangp
Copy link
Member

@juanangp juanangp commented Jun 29, 2022 •
edited by pull-request-badge bot
Loading

juanangp Medium: 119

Added new workflow for automatic merging of submodule PR when a submodule branch matches and a submodule PR exist:

  • Check if any submodule branch matches framework branch
  • In case a branch matches it check if a PR in the submodule exist
  • Workflow will fail in case a matching submodule branch exist and there is no associated PR
  • When the framework PR is merged, the associated submodules PR should be also merged
  • Access tokens for the submodule merge are taken from the repository

Contributes to #250

Related to rest-for-physics/rawlib#71

@juanangp juanangp mentioned this pull request Jun 30, 2022
Open
@juanangp juanangp marked this pull request as ready for review July 1, 2022 10:57
@juanangp juanangp requested review from jgalan and lobis July 1, 2022 10:57
@juanangp
Copy link
Member Author

juanangp commented Jul 1, 2022

@lobis and @jgalan can you approve please? I want to check if the pipeline passes after approval, also you have to approve this one rest-for-physics/rawlib#71

@jgalan
Copy link
Member

jgalan commented Aug 30, 2022

This PR is not yet merged?

@jgalan jgalan linked an issue Sep 22, 2022 that may be closed by this pull request
Automatize submodule PR if framework name matches with submodules #250
Open
@jgalan
Copy link
Member

jgalan commented Sep 22, 2022

@juanangp should this be merged together with rest-for-physics/rawlib#71?

@jgalan jgalan linked an issue Sep 22, 2022 that may be closed by this pull request
Launch libraries pipelines #274
Open
@juanangp juanangp mentioned this pull request Apr 27, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgalan jgalan jgalan approved these changes

@lobis lobis lobis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Launch libraries pipelines Automatize submodule PR if framework name matches with submodules
3 participants
@juanangp @jgalan @lobis