Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Antithesis regression test #396

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

ableegoldman
Copy link
Contributor

Played myself here by making the #1 most common mistake for Kafka Streams users: not realizing when/where you need to explicitly set serdes

@ableegoldman ableegoldman requested a review from agavra November 22, 2024 03:43
@ableegoldman
Copy link
Contributor Author

Just gonna merge this right right away since it's a simple one-liner

Might be nice to have an integration test or something that runs regularly (or is Disabled but can be run when needed) so we can debug/avoid breaking the Antithesis stuff. Not a huge priority right now though 🙃

@ableegoldman ableegoldman merged commit 9e29126 into main Nov 22, 2024
1 check failed
@ableegoldman ableegoldman deleted the ANTITHESIS-fix-regression-test branch November 22, 2024 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant