use cluster default for compaction strategy #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| import dev.responsive.kafka.internal.db.partitioning.TablePartitioner; | ||
| import dev.responsive.kafka.internal.stores.TtlResolver; | ||
| import java.util.Optional; | ||
|
|
||
| public class DefaultTableSpec implements RemoteTableSpec { | ||
|
|
||
| private static final CompactionStrategy<?> DEFAULT_CASSANDRA_COMPACTION_STRATEGY = | ||
| new DefaultLeveledCompactionStrategy(); |
There was a problem hiding this comment.
The reason I chose this was because I saw it was used as the default in a few places (maybe not everywhere like I thought) -- we should make sure we keep this in those places right?
There was a problem hiding this comment.
Sadly I don't remember off the top of my head but I think if you do a search for the DefaultLeveledCompactionStrategy in my first TTL PR it should show where it used to be used
There was a problem hiding this comment.
(lmk if you want my help in finding that)
There was a problem hiding this comment.
I think ICS is generally a good general starting point, and since we don't have prod deployments of other compaction strategies I'm keen to just keep the default.
ableegoldman
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a regression in #371 where we started specifying LCS as the default compaction strategy. This change uses the cluster default instead, so that it will use ICS in scylla enterprise clusters (which ScyllaDB cloud are by default).
We can't test this easily since the scyllaDB public docker images don't have ICS, but I verified manually that this works.