Row-level TTL PR 9: TTD test with ttl deduplicator #381
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,84 @@ | ||
| /* | ||
| * Copyright 2024 Responsive Computing, Inc. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package dev.responsive.kafka.testutils.processors; | ||
|
|
||
| import static dev.responsive.kafka.testutils.processors.GenericProcessorSuppliers.getFixedKeySupplier; | ||
|
|
||
| import dev.responsive.kafka.api.stores.ResponsiveKeyValueParams; | ||
| import dev.responsive.kafka.api.stores.ResponsiveStores; | ||
| import org.apache.kafka.common.serialization.Serdes; | ||
| import org.apache.kafka.streams.StreamsBuilder; | ||
| import org.apache.kafka.streams.Topology; | ||
| import org.apache.kafka.streams.kstream.KStream; | ||
| import org.apache.kafka.streams.processor.api.FixedKeyProcessor; | ||
| import org.apache.kafka.streams.processor.api.FixedKeyProcessorContext; | ||
| import org.apache.kafka.streams.processor.api.FixedKeyRecord; | ||
| import org.apache.kafka.streams.state.TimestampedKeyValueStore; | ||
| import org.apache.kafka.streams.state.ValueAndTimestamp; | ||
|
|
||
| public class Deduplicator { | ||
|
|
||
| public static Topology deduplicatorApp( | ||
| final String inputTopicName, | ||
| final String outputTopicName, | ||
| final ResponsiveKeyValueParams params | ||
| ) { | ||
| final StreamsBuilder builder = new StreamsBuilder(); | ||
| final KStream<String, String> input = builder.stream(inputTopicName); | ||
|
|
||
| final var storeBuilder = ResponsiveStores.timestampedKeyValueStoreBuilder( | ||
| ResponsiveStores.keyValueStore(params), Serdes.String(), Serdes.String() | ||
| ); | ||
| final String storeName = params.name().kafkaName(); | ||
| input | ||
| .processValues(getFixedKeySupplier(DeduplicatorProcessor::new, storeBuilder), storeName) | ||
| .to(outputTopicName); | ||
|
|
||
| return builder.build(); | ||
| } | ||
|
|
||
| private static class DeduplicatorProcessor implements FixedKeyProcessor<String, String, String> { | ||
|
|
||
| private final String storeName; | ||
|
|
||
| private FixedKeyProcessorContext<String, String> context; | ||
| private TimestampedKeyValueStore<String, String> ttlStore; | ||
|
|
||
| public DeduplicatorProcessor(final String storeName) { | ||
| this.storeName = storeName; | ||
| } | ||
|
|
||
| @Override | ||
| public void init(final FixedKeyProcessorContext<String, String> context) { | ||
| this.context = context; | ||
| this.ttlStore = context.getStateStore(storeName); | ||
| } | ||
|
|
||
| @Override | ||
| public void process(final FixedKeyRecord<String, String> record) { | ||
| final ValueAndTimestamp<String> previous = ttlStore.putIfAbsent( | ||
| record.key(), | ||
| ValueAndTimestamp.make(record.value(), record.timestamp()) | ||
| ); | ||
|
|
||
| if (previous == null) { | ||
| context.forward(record); | ||
| } | ||
|
|
||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,100 @@ | ||
| /* | ||
| * Copyright 2024 Responsive Computing, Inc. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package dev.responsive.kafka.testutils.processors; | ||
|
|
||
| import java.util.Collections; | ||
| import java.util.Set; | ||
| import java.util.function.Function; | ||
| import org.apache.kafka.streams.processor.api.FixedKeyProcessor; | ||
| import org.apache.kafka.streams.processor.api.FixedKeyProcessorSupplier; | ||
| import org.apache.kafka.streams.processor.api.Processor; | ||
| import org.apache.kafka.streams.processor.api.ProcessorSupplier; | ||
| import org.apache.kafka.streams.state.StoreBuilder; | ||
|
|
||
| public class GenericProcessorSuppliers { | ||
|
|
||
| public static <KIn, VIn, KOut, VOut> ProcessorSupplier<KIn, VIn, KOut, VOut> getSupplier( | ||
| final Function<String, Processor<KIn, VIn, KOut, VOut>> processorForStoreName, | ||
| final StoreBuilder<?> storeBuilder | ||
| ) { | ||
| return new GenericProcessorSupplier<>(processorForStoreName, storeBuilder); | ||
| } | ||
|
|
||
| public static <KIn, VIn, VOut> FixedKeyProcessorSupplier<KIn, VIn, VOut> getFixedKeySupplier( | ||
| final Function<String, FixedKeyProcessor<KIn, VIn, VOut>> processorForStoreName, | ||
| final StoreBuilder<?> storeBuilder | ||
| ) { | ||
| return new GenericFixedKeyProcessorSupplier<>(processorForStoreName, storeBuilder); | ||
| } | ||
|
|
||
| private static class GenericProcessorSupplier<KIn, VIn, KOut, VOut> | ||
| implements ProcessorSupplier<KIn, VIn, KOut, VOut> { | ||
|
|
||
| private final Function<String, Processor<KIn, VIn, KOut, VOut>> processorForStoreName; | ||
| private final StoreBuilder<?> storeBuilder; | ||
|
|
||
| public GenericProcessorSupplier( | ||
| final Function<String, Processor<KIn, VIn, KOut, VOut>> processorForStoreName, | ||
| final StoreBuilder<?> storeBuilder | ||
| ) { | ||
| this.processorForStoreName = processorForStoreName; | ||
| this.storeBuilder = storeBuilder; | ||
| } | ||
|
|
||
| @Override | ||
| public Processor<KIn, VIn, KOut, VOut> get() { | ||
| return processorForStoreName.apply(storeBuilder.name()); | ||
| } | ||
|
|
||
| @Override | ||
| public Set<StoreBuilder<?>> stores() { | ||
| if (storeBuilder != null) { | ||
| return Collections.singleton(storeBuilder); | ||
| } | ||
| return null; | ||
| } | ||
| } | ||
|
|
||
| private static class GenericFixedKeyProcessorSupplier<KIn, VIn, VOut> | ||
| implements FixedKeyProcessorSupplier<KIn, VIn, VOut> { | ||
|
|
||
| private final Function<String, FixedKeyProcessor<KIn, VIn, VOut>> processorForStoreName; | ||
| private final StoreBuilder<?> storeBuilder; | ||
|
|
||
| public GenericFixedKeyProcessorSupplier( | ||
| final Function<String, FixedKeyProcessor<KIn, VIn, VOut>> processorForStoreName, | ||
| final StoreBuilder<?> storeBuilder | ||
| ) { | ||
| this.processorForStoreName = processorForStoreName; | ||
| this.storeBuilder = storeBuilder; | ||
| } | ||
|
|
||
| @Override | ||
| public FixedKeyProcessor<KIn, VIn, VOut> get() { | ||
| return processorForStoreName.apply(storeBuilder.name()); | ||
| } | ||
|
|
||
| @Override | ||
| public Set<StoreBuilder<?>> stores() { | ||
| if (storeBuilder != null) { | ||
| return Collections.singleton(storeBuilder); | ||
| } | ||
| return null; | ||
| } | ||
| } | ||
|
|
||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll admit I had to ask chatGPT how to access the stuff in the testutils of
kafka-clientfrom the tests inresponsive-test-utils, and this was how it said to do it. Not sure it's necessary the right way to do so, if you have a different suggestionThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤷 when it comes to build systems, if it works it works