Row-level TTL PR 7: TopologyTestDriver#advanceWallClockTime #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ableegoldman
commented
Nov 1, 2024
| @@ -142,6 +142,64 @@ public void shouldRunWithoutResponsiveConnectionAndKeyBasedTtl(final KVSchema ty | |||
| driver.close(); | |||
| } | |||
|
|
|||
| @ParameterizedTest | |||
| @EnumSource(SchemaTypes.KVSchema.class) | |||
| public void shouldEnforceKeyBasedTtlByAdvancingWallclockTime(final KVSchema type) { | |||
There was a problem hiding this comment.
verified that this test failed without the fix
This was referenced Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor followup to PR #6 where we changed the TTD so that only advancing stream-time by piping additional input records would apply ttl. Although this more closely matches how the TTD has to be used in vanilla Streams, it's a pain to be unable to advance the time on its own without being coupled to the input records. This PR restores the previous semantics of the ResponsiveTopologyTestDriver#advanceWallClockTime API so that this can be used to validate ttl in TTD tests
PR 1: API #370
PR 2: TtlResolver #371
PR 3: compute minValidTs from TtlResolver #373
PR 4: CassandraFactTable implementation #374
PR 5: extract StateSerdes #375
PR 6: support for ResponsiveTopologyTestDriver #376