checkstyle

responsivedev · Dec 16, 2024 · 0dcf9ba · 0dcf9ba
1 parent 1815633
commit 0dcf9ba
Show file tree

Hide file tree

Showing 7 changed files with 8 additions and 11 deletions.
diff --git a/kafka-client/src/main/java/dev/responsive/kafka/api/ResponsiveKafkaStreams.java b/kafka-client/src/main/java/dev/responsive/kafka/api/ResponsiveKafkaStreams.java
@@ -12,8 +12,6 @@
 
 package dev.responsive.kafka.api;
 
-import static dev.responsive.kafka.api.config.ResponsiveConfig.ASYNC_MAX_EVENTS_QUEUED_PER_ASYNC_THREAD_CONFIG;
-import static dev.responsive.kafka.api.config.ResponsiveConfig.ASYNC_THREAD_POOL_SIZE_CONFIG;
 import static dev.responsive.kafka.api.config.ResponsiveConfig.DYNAMODB_ENDPOINT_CONFIG;
 import static dev.responsive.kafka.api.config.ResponsiveConfig.METRICS_ENABLED_CONFIG;
 import static dev.responsive.kafka.api.config.ResponsiveConfig.MONGO_ADDITIONAL_CONNECTION_STRING_PARAMS_CONFIG;
@@ -607,6 +605,7 @@ public Params build() {
               false,
               admin
           );
+          break;
         case IN_MEMORY:
           LOG.info("using in-memory responsive store");
           sessionClients = new SessionClients(

diff --git a/kafka-client/src/main/java/dev/responsive/kafka/internal/db/DynamoClient.java b/kafka-client/src/main/java/dev/responsive/kafka/internal/db/DynamoClient.java
@@ -12,11 +12,8 @@
 
 package dev.responsive.kafka.internal.db;
 
-import com.mongodb.client.model.WriteModel;
 import dev.responsive.kafka.api.config.ResponsiveConfig;
 import dev.responsive.kafka.internal.db.dynamo.DynamoKVTable;
-import dev.responsive.kafka.internal.db.mongo.KVDoc;
-import dev.responsive.kafka.internal.db.mongo.MongoKVTable;
 import dev.responsive.kafka.internal.db.partitioning.TablePartitioner;
 import dev.responsive.kafka.internal.db.spec.DefaultTableSpec;
 import dev.responsive.kafka.internal.stores.TtlResolver;

diff --git a/kafka-client/src/main/java/dev/responsive/kafka/internal/db/dynamo/DynamoKVFlushManager.java b/kafka-client/src/main/java/dev/responsive/kafka/internal/db/dynamo/DynamoKVFlushManager.java
@@ -59,7 +59,10 @@ public TablePartitioner<Bytes, Integer> partitioner() {
   }
 
   @Override
-  public RemoteWriter<Bytes, Integer> createWriter(final Integer tablePartition) {
+  public RemoteWriter<Bytes, Integer> createWriter(
+      final Integer tablePartition,
+      final long consumedOffset
+  ) {
     return new DynamoWriter<>(table, kafkaPartition, tablePartition, dynamo);
   }
 

diff --git a/kafka-client/src/main/java/dev/responsive/kafka/internal/db/dynamo/DynamoKVTable.java b/kafka-client/src/main/java/dev/responsive/kafka/internal/db/dynamo/DynamoKVTable.java
@@ -30,7 +30,6 @@
 import software.amazon.awssdk.services.dynamodb.model.AttributeDefinition;
 import software.amazon.awssdk.services.dynamodb.model.AttributeValue;
 import software.amazon.awssdk.services.dynamodb.model.BillingMode;
-import software.amazon.awssdk.services.dynamodb.model.ConditionalCheckFailedException;
 import software.amazon.awssdk.services.dynamodb.model.CreateTableRequest;
 import software.amazon.awssdk.services.dynamodb.model.DeleteItemRequest;
 import software.amazon.awssdk.services.dynamodb.model.DynamoDbRequest;
@@ -41,7 +40,6 @@
 import software.amazon.awssdk.services.dynamodb.model.PutItemRequest;
 import software.amazon.awssdk.services.dynamodb.model.ResourceInUseException;
 import software.amazon.awssdk.services.dynamodb.model.ReturnValue;
-import software.amazon.awssdk.services.dynamodb.model.ReturnValuesOnConditionCheckFailure;
 import software.amazon.awssdk.services.dynamodb.model.ScalarAttributeType;
 import software.amazon.awssdk.services.dynamodb.model.UpdateItemRequest;
 

diff --git a/kafka-client/src/test/java/dev/responsive/kafka/integration/MinimalIntegrationTest.java b/kafka-client/src/test/java/dev/responsive/kafka/integration/MinimalIntegrationTest.java
@@ -65,7 +65,7 @@
  * the development workflow, and therefore is disabled by default (to speed
  * up test time).
  */
-//@Disabled
+@Disabled
 public class MinimalIntegrationTest {
 
   @RegisterExtension

diff --git a/...test/java/dev/responsive/kafka/integration/ResponsiveKeyValueStoreEosIntegrationTest.java b/...test/java/dev/responsive/kafka/integration/ResponsiveKeyValueStoreEosIntegrationTest.java
@@ -38,7 +38,6 @@
 import static org.hamcrest.Matchers.lessThan;
 
 import dev.responsive.kafka.api.ResponsiveKafkaStreams;
-import dev.responsive.kafka.api.config.StorageBackend;
 import dev.responsive.kafka.api.stores.ResponsiveKeyValueParams;
 import dev.responsive.kafka.api.stores.ResponsiveStores;
 import dev.responsive.kafka.internal.stores.SchemaTypes.KVSchema;

diff --git a/kafka-client/src/test/java/dev/responsive/kafka/testutils/TestConstants.java b/kafka-client/src/test/java/dev/responsive/kafka/testutils/TestConstants.java
@@ -19,6 +19,7 @@ public class TestConstants {
   public static final DockerImageName CASSANDRA = DockerImageName.parse("cassandra:4.1.0");
   public static final DockerImageName KAFKA = DockerImageName.parse("confluentinc/cp-kafka:7.3.2");
   public static final DockerImageName MONGODB = DockerImageName.parse("mongo:7.0.2");
-  public static final DockerImageName DYNAMODB = DockerImageName.parse("amazon/dynamodb-local:2.2.1");
+  public static final DockerImageName DYNAMODB =
+      DockerImageName.parse("amazon/dynamodb-local:2.2.1");
 
 }