Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed versions in develop mode; Module docstrings; More Env Improvements #185

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

aufdenkampe
Copy link
Collaborator

@aufdenkampe aufdenkampe commented Dec 17, 2024

This PR:

  • Fixes the version attribute import error when in conda develop mode, while also preserving the versioning for packaging. It does so by moving the code from _version.py into the main init file. Thanks @ptomasula for helping me work through this "cake-and-eat-it-too" approach!
  • Adds module-level docstrings.
  • Updates environment files to follow conventions (i.e. putting Python version at top; put env managment at the bottom).
  • Changed default environment name to hsp2 and unconstrained Python to >=3.10.

In my test of these updates to environment.yml, conda installed Python 3.12.8, and everything worked well.

cc: @timcera

To follow conventions (i.e. putting Python version at top; put env managment at the bottom). Also changed default env name to `hsp2` and unconstrained Python to >=3.10
…docstrings

@timcera, this commit fixes the version attribute import error when in conda develop mode, while also preserving the versioning for packaging. It does so by moving the code from `_version.py` into the main init file. Thanks @ptomasula for helping me work through this "cake-and-eat-it-too" approach!
@timcera
Copy link
Contributor

timcera commented Dec 17, 2024

Nice!

Copy link
Member

@PaulDudaRESPEC PaulDudaRESPEC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good!

@PaulDudaRESPEC PaulDudaRESPEC merged commit 3701c3d into develop Dec 17, 2024
11 checks passed
@aufdenkampe aufdenkampe deleted the conda_tweaks branch December 18, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants