-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge Develop in Main in preparation for new release #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g R scripts or even running R inside the dirs
Added a couple R files to ignore to keep the repo clean when includin…
recent small fixes into develop
First attempt to initiate automated testing
try to change to node20 from node16
2nd try node.js
use v4 instead of v3 - does this fix node js 20 issue?
simplified tests using newer info from https://docs.github.com/en/[email protected]/actions/automating-builds-and-tests/building-and-testing-python
try v5 since v4 still seems to be deprecated even though the docs "seem" to say going from 3 to 4 will fix.
try py 3.9
…uggests it should?)
ignore missing variables (since `_version` is loaded via an include). to fix CI script failure with code `F821` see #135 (comment)
ignore ACIDPH.py because it uses a weird sci notation format AC (i.e. I think `rkal1 = 1.03d-5` should be `rkal1 = 1.03e-5` etc)
…ch, added domain specific specl filter in HYDR
tests for spec actions
…ated as registers that get zeroed
…special case of ModelVariable, and then ModelVariable can form the base class for simple numerical data holders like UVQUAN
Develop spec lean
* Moved the HSP2, HSP2IO, and HSP2tools top level packages to hsp2.hsp2, hsp2.hsp2io, and hsp2.hsp2tools respectively. * Corrected the imports in python and Jupyter notebooks to use the new locations. * HSP2 can be run in all of the CompareHSP2.ipynb in tests/, however some do not have the HSPF results to compare to. * The Jupyter notebooks in examples/ need some work to find input data and where to write output.
Move to single python package "hsp2" Nice work, thanks @timcera !
…me print statements related to new om implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.