Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancements for custom python SPECL, small GENER fixes #120

Merged
merged 101 commits into from
Oct 24, 2023
Merged

Conversation

PaulDudaRESPEC
Copy link
Member

No description provided.

PaulDudaRESPEC and others added 30 commits July 8, 2022 15:12
…ing initial state variable table, and fill with default values. Addresses Issue #96 where the IWAT-STATE1 table did not exist in the UCI.
…or use in advection, correcting a potential problem with initial non-zero outflows
specl functions defined and initial testing successful
Constrained JupyterLab version and removed optional plugins, due to JupyterLab updates starting causing errors. Clarified installation instructions to better separate the two installation options, which are mutually exclusive.
The time series for inorganic species of nutrients was being assigned an incorrect key in the timeseries dictionary returned by the utlities.get_stimeseries function. The timeseries were not coded with an underscore between the TMEMN and TMEMSB definition as expected by the RQUAL module (https://github.com/respec/HSPsquared/blob/f9555f2e48cc3409f33c29d3c6504d9bdc0f91fb/HSP2/RQUAL_Class.py#L439-L449).
This Python 3.9 environment is basically the same I used for demos and testing in Jan. 2022.
incorrect timeseries key assignment for inorganic nutrient species
test passing the TS and modifying the last step value
rburghol and others added 27 commits June 21, 2023 21:32
Fix pip install bug when jupyter lab version restricted to 3.0.*
•	Fix to Celsius conversion precision in PSTEMP
•	AGWO precision in PWATER
•	GWVS cut off in PWATER
•	Atmos Dep not getting added to totals in NUTRX and PLANK
•	PKIF inflow in get_timeseries
@PaulDudaRESPEC PaulDudaRESPEC merged commit 8e4e9ba into master Oct 24, 2023
@PaulDudaRESPEC
Copy link
Member Author

Hi @aufdenkampe , yes, there's a lot of good stuff in here. I plan to do more testing this week and hopefully by the end of the week I can make an updated release -- as well as tic off some of those issues -- stay tuned!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants