add python bindings for GPs #289
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems okay to me. Just leaving a comment that this is NOT thread-safe (in case we will forget it in the future). Btw, @jbmouret maybe we should add something about this binding to the documentation/README? |
|
This is amazing, thanks for this ❤️ |
|
https://github.com/opensim-org/opensim-core/pull/2773/files Apparently we need to add |
|
I have been using limbo on and off for "simple GP" stuff, so I think I can
try and push the fix this week.
No mac to validate it though, I can test it myself on Ubuntu/Windows conda.
El dom., 24 may. 2020 a las 17:52, JB Mouret (<[email protected]>)
escribió:
… https://github.com/opensim-org/opensim-core/pull/2773/files
Apparently we need to change some flags to get it to work on mac with
conda.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#289 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABZF63BWGUIR5F4PGEO4TY3RTGCJLANCNFSM4GARDVRQ>
.
|
No worries! Push the fix and I guess @jbmouret can test it on his machine. Thanks! |
According to https://stackoverflow.com/questions/25421479/clang-and-undefined-symbols-when-building-a-library the flag is specific to OSX, it shouldn't impact other builds.
|
Sorry for the delay on pushing this, I guess it should work properly now on mac with conda. Thanks! |
|
I will try, but this will take me some time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.