Unpriced collateral #1220
Unpriced collateral #1220
Conversation
|
|
||
| mapping(address coll => uint192 feePerSecond) public demurrageDeployments; | ||
| mapping(address coll => uint192 feePerSecond) public demurrageDeployments; // not unique by erc20 |
There was a problem hiding this comment.
address erc20 => uint256/uint192 fee => address collateral is much better to query and track.
There was a problem hiding this comment.
can't do that -- permissionless pass-in of all variables
There was a problem hiding this comment.
there is not just 1 collateral possible, per fee tier
There was a problem hiding this comment.
Sorry I meant for unpriced demurrage collateral. There aren't any specific parameters for those, I don't think right?
There was a problem hiding this comment.
that's 2 lines below and works the way you want it to
There was a problem hiding this comment.
well it's saving by address of the deployed collateral. maybe this comment should go in the other pr, but if we save a mapping like akshat suggested (and error on duplicates), then the fe can easily query the contract based on the erc20 addy. otherwise we're requiring a subgraph dependency
tbrent
force-pushed
the
unpriced-collateral
branch
from
dd4dd1d to
c40b322
Compare
|
tabling plans to use unpriced collateral for now |
No description provided.