-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanup slithering, add pipeline job. #1024
Conversation
doing a full cleanup and validation of all slither results is a much larger ticket, maybe 13 at least. this pr adds a job to the pipeline and cleans up some the current HIGH issues raised by slither (verified to be non-issues), as well as a few mediums. it also excludes LOW, INFORMATIONAL, and OBSERVATIONS form the output. |
cleanup slithering, add pipeline job.
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small nit but other than that LGTM. It's unfortunate there's no detector for implicit up-casts, or something similar. Still, this improves CI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.