Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup slithering, add pipeline job. #1024

Merged
merged 4 commits into from
Jan 8, 2024
Merged

cleanup slithering, add pipeline job. #1024

merged 4 commits into from
Jan 8, 2024

Conversation

pmckelvy1
Copy link
Collaborator

No description provided.

@pmckelvy1
Copy link
Collaborator Author

doing a full cleanup and validation of all slither results is a much larger ticket, maybe 13 at least.

this pr adds a job to the pipeline and cleans up some the current HIGH issues raised by slither (verified to be non-issues), as well as a few mediums. it also excludes LOW, INFORMATIONAL, and OBSERVATIONS form the output.

Copy link

openzeppelin-code bot commented Dec 7, 2023

cleanup slithering, add pipeline job.

Generated at commit: 76e52492dbf25a4d8a605303b6e616e154021a87

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
2
1
0
18
35
56
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@pmckelvy1 pmckelvy1 requested a review from tbrent December 12, 2023 01:31
Copy link
Collaborator

@tbrent tbrent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nit but other than that LGTM. It's unfortunate there's no detector for implicit up-casts, or something similar. Still, this improves CI.

contracts/facade/FacadeAct.sol Outdated Show resolved Hide resolved
tbrent
tbrent previously approved these changes Dec 18, 2023
Copy link
Collaborator

@tbrent tbrent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tbrent tbrent merged commit 25e3598 into master Jan 8, 2024
10 checks passed
@tbrent tbrent deleted the cleanup-slither branch January 8, 2024 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants