-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invariant Monitor contract #1017
Conversation
im thinking its probably worth it to split this contract up into multiple. it would be a lot easier to maintain each individual monitoring function if they need to be tweaked or upgraded (less gas costs to do individual deployments). |
maybe for simplicity's sake, we just make this a proxy and use a single contract for now. if we get to a point of wanting to make change or add functionality, we can reassess if a single contract is the best route, but for now, a single upgradeable proxy is probably easiest. the only concern there is who is the admin? i think there is a msig we can use to approve upgrades. |
Invariant Monitor contract
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
…rotocol into feat-invariantmonitor
@pmckelvy1 This is ready, included the morpho change, deployed and upgraded the monitors in Base and Mainnet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
*Includes deployment address and docs
Deployment task available:
For the initial deployment:
npx hardhat deploy-facade-monitor --upgrade false --owner OWNER_ADDR --network mainnet
For deploying just the new implementation to be used in upgrade:
npx hardhat deploy-facade-monitor --upgrade true --network mainnet