add lotPrice() back everywhere (unused) for backwards compatibility

[tbrent]

I realized while writing down 3.1.0 upgrade instructions that we can't pull lotPrice() off the assets + basketHandler if this is going to be a minor release. I've added it back everywhere with lotPrice() just returning the result of price().

[pmckelvy1]

worth adding back all the relevant tests?

[tbrent]

worth adding back all the relevant tests?

Well the behavior changed, the old tests would fail now. I do think it's worth adding new tests though just to make sure lotPrice() is implemented and that it returns the same thing as price(), will do.

[openzeppelin-code]

add lotPrice() back everywhere (unused) for backwards compatibility

Generated at commit: e2b9359790094ec63a61e3b23b77db206850d835

🚨 Vulnerabilities Summary

Process	Issues	Results
Contract Inspector	high note low critical Total	1 35 18 2 56
Dependency Checker	Total	0

---

For more details view the full report in OpenZeppelin Code

[tbrent]

I've added tests to check that (i) lotPrice() is on all asset interfaces; and (ii) lotPrice() returns the same thing as price()

[pmckelvy1]

let's add them for RTokenAsset and BasketHandler as well

[tbrent]

let's add them for RTokenAsset and BasketHandler as well

Good catch, added