Watcher / After build command #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolandpeelen
force-pushed
the
watcher-command
branch
from
1470160
to
fd2a951
Compare
added 3 commits
July 21, 2023 12:23
This is an issue when running things like a test watcher simultaniously with Rewatch. Because of the amount of IO Rewacht produces, the watcher in the secondary thread get's respawned over-and-over, making it produce more IO than needed. This allows the user to pass in a subcommand to be ran whenever the build has finished. IE: ``` rewatch watch . -a "yarn jest foo.test" ``` Or, when there are longer build times, alert the user that the build is finished. ``` rewatch watch . -a "tput bel" ```
rolandpeelen
force-pushed
the
watcher-command
branch
from
fd2a951
to
6620dd0
Compare
|
This is cool and quite useful for codegen tools that rely on build artifacts, like ResGraph (https://github.com/zth/resgraph). One thought I had - would it be feasible to track and relay a list of all files that rebuilt to the command that gets invoked? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an issue when running things like a test watcher simultaniously
with Rewatch. Because of the amount of IO Rewacht produces, the watcher
in the secondary thread get's respawned over-and-over, making it produce
more IO than needed. This allows the user to pass in a subcommand to be
ran whenever the build has finished. IE:
Or, when there are longer build times, alert the user that the build is
finished.
Effectively this means we have a way for the user to tap into the watcher, and spawn commands there, rather than relying on starting an additional watcher.