Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: strict types for form events #106

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ivan-demchenko
Copy link

This PR makes use of Js.Json.t instead of object type for form events. It addresses this issue:
#105

Context:

let targetValueToInt = (target: Js.Json.t): int => {
 // Js.Json.decodeObject(target)) 
 // and so on
}
// ...
<input
  onChange={
    evt => {
      setIntValue(_prev => evt->ReactEvent.Form.target->targetValueToInt);
    }
  }
/>

@mununki
Copy link
Member

mununki commented Jan 8, 2024

Thank you for PR!
The big difference between object and JSON is that undefined doesn't exist in JSON's specification. I'm not sure why we need to type-define form event as JSON format instead of object, can you explain further?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants