Fix js ouput of bigint max, min #7088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since there were no tests for max and min, it seems we were unable to identify issues during testing. Therefore, I have added the necessary tests. |
cometkim
reviewed
Oct 7, 2024
jscomp/core/lam_compile_primitive.ml
Outdated
| @@ -416,7 +416,7 @@ let translate output_prefix loc (cxt : Lam_compile_context.t) | |||
| | _ -> assert false) | |||
| | Pbigintmax -> ( | |||
| match args with | |||
| | [ { expression_desc = Number (Float _) } as a; { expression_desc = Number (Float _) } as b ] | |||
| | [ { expression_desc = Number (BigInt _) } as a; { expression_desc = Number (BigInt _) } as b ] | |||
| when Js_analyzer.is_okay_to_duplicate a && Js_analyzer.is_okay_to_duplicate b -> | |||
| E.econd (E.js_comp Cgt a b) a b | |||
There was a problem hiding this comment.
Use E.bigint_comp here should improve the outputs
There was a problem hiding this comment.
Hmm ok E.econd itself doesn't seem to be optimized enough yet
cometkim
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue where max, min operations generate js ouput incorrectly. It is described in the related issue #7062 (comment)