Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the blueprint saving logic to re_viewer_blueprint #8717

Merged
merged 3 commits into from
Jan 16, 2025

Conversation

abey79
Copy link
Member

@abey79 abey79 commented Jan 16, 2025

What

By just reshuffling things around, I think this makes re_viewer_blueprint self-contained enough to be used from tests. This will be attempted in #8706

@abey79 abey79 added 🔨 testing testing and benchmarks 🚜 refactor Change the code, not the functionality exclude from changelog PRs with this won't show up in CHANGELOG.md labels Jan 16, 2025
Copy link

github-actions bot commented Jan 16, 2025

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
cc069ab https://rerun.io/viewer/pr/8717 +nightly +main

Note: This comment is updated whenever you push a commit.

@Wumpf Wumpf self-requested a review January 16, 2025 15:21
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't diff the moved thing but I don't have any grudge against the concept this moving from there to there so lgtm :)

@Wumpf Wumpf merged commit 3deb7af into main Jan 16, 2025
31 checks passed
@Wumpf Wumpf deleted the antoine/refactor-blueprint-viewport branch January 16, 2025 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md 🚜 refactor Change the code, not the functionality 🔨 testing testing and benchmarks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants