Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky re_graph_view test by removing dynamically-placed node #8683

Merged
merged 4 commits into from
Jan 14, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions crates/viewer/re_view_graph/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -43,4 +43,5 @@ nohash-hasher.workspace = true
[dev-dependencies]
egui_kittest.workspace = true
re_chunk_store.workspace = true
re_viewer_context = { workspace = true, features = ["testing"] }
re_viewport.workspace = true
6 changes: 4 additions & 2 deletions crates/viewer/re_view_graph/tests/basic.rs
Original file line number Diff line number Diff line change
Expand Up @@ -89,9 +89,11 @@ pub fn self_and_multi_edges() {
components::GraphEdge(("B", "A").into()),
// duplicated self-edges
components::GraphEdge(("A", "A").into()),
// TODO(grtlr): investigate instabilities in the graph layout to be able
// to test dynamically placed nodes.
// implicit edges
components::GraphEdge(("B", "C").into()),
components::GraphEdge(("C", "C").into()),
// components::GraphEdge(("B", "C").into()),
// components::GraphEdge(("C", "C").into()),
];

let directed = components::GraphType::Directed;
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading