-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use egui_kittest
for the graph view
#8578
Draft
grtlr
wants to merge
7
commits into
main
Choose a base branch
from
grtlr/kittest-graph-view
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+395
−141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Andreas Reich <[email protected]>
grtlr
added
🔨 testing
testing and benchmarks
exclude from changelog
PRs with this won't show up in CHANGELOG.md
labels
Jan 3, 2025
Web viewer failed to build.
Note: This comment is updated whenever you push a commit. |
Wumpf
reviewed
Jan 3, 2025
harness.run(); | ||
|
||
//TODO(#8245): enable this everywhere when we have a software renderer setup | ||
// #[cfg(target_os = "macos")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to keep this in for now
Wumpf
reviewed
Jan 3, 2025
@@ -15,18 +15,12 @@ | |||
* `graph` has directed edges, while `graph2` has undirected edges. | |||
* `graph` and `graph2` are shown in two different viewers. | |||
* There is a third viewer, `Both`, that shows both `graph` and `graph2` in the same viewer. | |||
* The `coincident` viewer shows two nodes, `A` and `B`, at the same position |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
less manual testing 🥳
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related
What
Title.
This might be a good starting point for other views wanting to adopt
egui_kittest
.Big shout out to @Wumpf how did all the query-crafting voodoo 🔮.