Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use egui_kittest for the graph view #8578

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Conversation

grtlr
Copy link
Contributor

@grtlr grtlr commented Jan 3, 2025

Related

What

Title.

This might be a good starting point for other views wanting to adopt egui_kittest.

Big shout out to @Wumpf how did all the query-crafting voodoo 🔮.

@grtlr grtlr added 🔨 testing testing and benchmarks exclude from changelog PRs with this won't show up in CHANGELOG.md labels Jan 3, 2025
Copy link

github-actions bot commented Jan 3, 2025

Web viewer failed to build.

Result Commit Link Manifest
59c2fea https://rerun.io/viewer/pr/8578 +nightly +main

Note: This comment is updated whenever you push a commit.

harness.run();

//TODO(#8245): enable this everywhere when we have a software renderer setup
// #[cfg(target_os = "macos")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to keep this in for now

@@ -15,18 +15,12 @@
* `graph` has directed edges, while `graph2` has undirected edges.
* `graph` and `graph2` are shown in two different viewers.
* There is a third viewer, `Both`, that shows both `graph` and `graph2` in the same viewer.
* The `coincident` viewer shows two nodes, `A` and `B`, at the same position
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

less manual testing 🥳

@grtlr grtlr marked this pull request as draft January 3, 2025 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md 🔨 testing testing and benchmarks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create snapshot tests for the graph view
2 participants