Skip to content

Commit

Permalink
Fix flaky re_graph_view test by removing dynamically-placed node (#…
Browse files Browse the repository at this point in the history
…8683)

### What

Title.

The downside of this is that we now skip the actual layout algorithm
entirely, as all nodes are placed at fixed positions.

I somehow need to figure out where the determinism in `fjadra` is coming
from:
* grtlr/fjadra#5
<!--
Make sure the PR title and labels are set to maximize their usefulness
for the CHANGELOG,
and our `git log`.

If you have noticed any breaking changes, include them in the migration
guide.

We track various metrics at <https://build.rerun.io>.

For maintainers:
* To run all checks from `main`, comment on the PR with `@rerun-bot
full-check`.
* To deploy documentation changes immediately after merging this PR, add
the `deploy docs` label.
-->

---------

Co-authored-by: Clement Rey <[email protected]>
  • Loading branch information
grtlr and teh-cmc authored Jan 14, 2025
1 parent 20b0b11 commit b2b7f91
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 4 deletions.
1 change: 1 addition & 0 deletions crates/viewer/re_view_graph/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -43,4 +43,5 @@ nohash-hasher.workspace = true
[dev-dependencies]
egui_kittest.workspace = true
re_chunk_store.workspace = true
re_viewer_context = { workspace = true, features = ["testing"] }
re_viewport.workspace = true
6 changes: 4 additions & 2 deletions crates/viewer/re_view_graph/tests/basic.rs
Original file line number Diff line number Diff line change
Expand Up @@ -89,9 +89,11 @@ pub fn self_and_multi_edges() {
components::GraphEdge(("B", "A").into()),
// duplicated self-edges
components::GraphEdge(("A", "A").into()),
// TODO(grtlr): investigate instabilities in the graph layout to be able
// to test dynamically placed nodes.
// implicit edges
components::GraphEdge(("B", "C").into()),
components::GraphEdge(("C", "C").into()),
// components::GraphEdge(("B", "C").into()),
// components::GraphEdge(("C", "C").into()),
];

let directed = components::GraphType::Directed;
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit b2b7f91

Please sign in to comment.