Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rider ide setup documentation #224

Merged
merged 3 commits into from
Aug 8, 2024
Merged

Conversation

Drew99Kt
Copy link
Contributor

@Drew99Kt Drew99Kt commented Jul 30, 2024

🤔 What's changed?

  • update rider documentation

⚡️ What's your motivation?

  • documentation being out of date caused us to spend 2-3 days trying to get rider working.

🏷️ What kind of change is this?

  • 📖 Documentation (improvements without changing code)

♻️ Anything particular you want feedback on?

  • I was unable to figure out how to build the site for local testing so i used a online md editor but i think it display correctly.

📋 Checklist:

  • I have updated the documentation accordingly.

request & included my GitHub handle to the release contributors list.

  • would be nice. looking forward to contributing any way i can.

This text was originally taken from the template of the Cucumber project, then edited by hand. You can modify the template here.

@Drew99Kt Drew99Kt changed the title Ide setup rider Rider ide setup documentation Jul 30, 2024
Copy link
Contributor

@ajeckmans ajeckmans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments, but overall it looks quite good!

docs/installation/setup-ide.md Outdated Show resolved Hide resolved
docs/installation/setup-ide.md Outdated Show resolved Hide resolved
docs/installation/setup-ide.md Show resolved Hide resolved
@Drew99Kt
Copy link
Contributor Author

Drew99Kt commented Jul 31, 2024

updated pr with suggestions.

Here is preview of "resolve suggestions" commit. @ajeckmans let me know if this works. thanks.
image

this is the live page for context
https://docs.reqnroll.net/latest/installation/setup-ide.html#setup-rider

@Drew99Kt Drew99Kt requested a review from ajeckmans July 31, 2024 23:35
Copy link

@ewitz ewitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@ajeckmans ajeckmans merged commit aba5ea7 into reqnroll:main Aug 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants