Allow overriding container image #44
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes reproducible-containers#42 Signed-off-by: Aurel Canciu <[email protected]>
AkihiroSuda
reviewed
Oct 18, 2024
| @@ -1,399 +1,1656 @@ | |||
| lockfileVersion: '6.0' | |||
| lockfileVersion: '9.0' | |||
There was a problem hiding this comment.
Probably this should be a separate PR?
AkihiroSuda
reviewed
Oct 18, 2024
| @@ -49,6 +51,7 @@ Options: | |||
| --cache-map The map of actions source paths to container destination paths or mount arguments | |||
| --scratch-dir Where the action is stores some temporary files for its processing. Default: 'scratch' | |||
| --skip-extraction Skip the extraction of the cache from the docker container | |||
| --container-image The container image to use for injecting and extracting the cache. Default: 'busybox:1' | |||
There was a problem hiding this comment.
What about calling this --utility-image?
Alternatively we may consider just using https://github.com/containerd/containerd/pkgs/container/busybox to avoid the Docker Hub rate limit? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #42
Not sure if the built dist files should be included in the PR or not. Let me know and I can remove them if needed.