New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WSGI middleware should call "close" on iterable if available #6

Open

kstark wants to merge 1 commit into repoze:master from GoodRx:call-close-on-iterable

kstark commented Dec 4, 2015

This was causing issues with our instrumentation.

It wasn't 100% clear to me how to handle close raising an exception, so I think there's a chance that abort might be called twice.


          WSGI middleware should call "close" on iterable if available

128e30b

Member

tseaver commented Jun 3, 2016

Thanks for the patch! Could you add a unit test showing that the iterable gets closed?

secretmike mentioned this pull request

Close iterable after iteration #7

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet