Stop swallowing dict returned by stdlib sendmail() #48
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One quirk of the sendmail method of Python stdlib is that it may return a dictionary of errors. This can happen when there are multiple recipients in the message being sent. The docs tell us:
(...) if this method does not raise an exception, then someone should get your mail. If this method does not raise an exception, it returns a dictionary, with one entry for each recipient that was refused. Each entry contains a tuple of the SMTP error code and the accompanying error message sent by the server.
It is necessary to allow that dictionary to reach the application, since it is the only code that knows how to deal with that situation. This is so clearly the case that the library pyramid_mailer, which reuses repoze.sendmail, assumes there's a return value and does return it to the application.
Existing tests pass but I did not add a new test. If you think I should, please let me know.