Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre-commit autoupdate check #568

Merged
merged 2 commits into from
Apr 11, 2024
Merged

Conversation

KAUTH
Copy link
Collaborator

@KAUTH KAUTH commented Mar 23, 2024

Description

  • Added a check in tox that warns if the pre-commit hook versions need updating.
  • Added this check as a pre-commit hook.
  • Removed pre-commit autoupdate from the Makefile since it's redundant

Similar to repository-service-tuf/repository-service-tuf-cli@9115d7d
Adding after #479

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)

Additional requirements

  • Tests have been added for the bug fix or new feature
  • Docs have been added for the bug fix or new feature

Code of Conduct

By submitting this PR, you agree to follow our Code of Conduct.

  • I agree to follow this project's Code of Conduct

@KAUTH KAUTH added the enhancement New feature or request label Mar 23, 2024
@KAUTH KAUTH requested a review from kairoaraujo March 23, 2024 13:52
@KAUTH KAUTH self-assigned this Mar 23, 2024
@MVrachev MVrachev self-requested a review April 9, 2024 14:47
@KAUTH KAUTH force-pushed the add-precommit-version-check-hook branch from 57d53ea to 7f8cc12 Compare April 9, 2024 21:53
- Added a check in tox that warns if the pre-commit
hook versions need updating.
- Added this check as a pre-commit hook.
- Removed `pre-commit autoupdate` from the Makefile
since it's redundant
@KAUTH KAUTH force-pushed the add-precommit-version-check-hook branch from 7f8cc12 to 2449d80 Compare April 10, 2024 11:55
@MVrachev MVrachev merged commit 4c44954 into main Apr 11, 2024
11 checks passed
@KAUTH KAUTH deleted the add-precommit-version-check-hook branch April 14, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

2 participants