-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#2195] Add cypress test for show tag when grouping by author and by none #2197
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the author-config.csv
to test this. I've left a few comments about the tests.
Also, I just realised that the tags feature does not work as expected when using the Group by None
option. Each author gets all of the tags of the repo instead of only the ones they tagged. Let's create a new issue for this.
@ckcherry23 the bug with group by none actually happened because of a change I made in this PR to fix group by author. i fixed the bug in this PR already, so all group by options should be working correctly. (also added some tests for this!) do i need to create a new issue + PR to address the original bug? |
If everything works as expected now, we do not need a new issue + PR. The current PR seems to have fixed all the issues, is there anything missing? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @jonasongg! Thanks for making the test cases more robust by comparing chart tags with those on the Zoom tab!
Please update the PR title and description to reflect that both test cases were added ('group by author' and 'group by none').
@ckcherry23 done, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
The following links are for previewing this pull request:
|
Fixes #2195
Proposed commit message
Other information