Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more repos to cypress tests #2188

Merged
merged 12 commits into from
Apr 18, 2024
Merged

Add more repos to cypress tests #2188

merged 12 commits into from
Apr 18, 2024

Conversation

jonasongg
Copy link
Contributor

@jonasongg jonasongg commented Apr 8, 2024 •
edited
Loading

Fixes #2187

Proposed commit message

Add more repos to Cypress tests

Currently, our Cypress config only tests with a single repo. This can
cause our testing to be limited and cause certain bugs to go
unnoticed.

Let's add more repos so that our testing can be more extensive.

Other information

@jonasongg jonasongg requested a review from a team April 8, 2024 05:35
@jonasongg jonasongg changed the title Add second repo to cypress tests Add more repos to cypress tests Apr 8, 2024
ckcherry23
ckcherry23 approved these changes Apr 13, 2024
View reviewed changes
Copy link
Member

@ckcherry23 ckcherry23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! We can add test cases for the bug in #2164 in a later PR.

@ckcherry23 ckcherry23 requested a review from a team April 13, 2024 09:21
vvidday
vvidday approved these changes Apr 13, 2024
View reviewed changes
Copy link
Contributor

@vvidday vvidday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great initiative, thanks! Will definitely help us catch more bugs in the future.

sopa301
sopa301 approved these changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@sopa301 sopa301 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ckcherry23 ckcherry23 merged commit 3c53d58 into master Apr 18, 2024
15 checks passed
@github-actions GitHub Actions
Copy link
Contributor

The following links are for previewing this pull request:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sopa301 sopa301 sopa301 approved these changes

@ckcherry23 ckcherry23 ckcherry23 approved these changes

@vvidday vvidday vvidday approved these changes

Assignees
No one assigned
Labels
s.ToMerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add more repos for Cypress frontend tests
4 participants
@jonasongg @vvidday @ckcherry23 @sopa301