Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lint warnings #2182

Merged
merged 5 commits into from
Apr 18, 2024
Merged

Fix lint warnings #2182

merged 5 commits into from
Apr 18, 2024

Conversation

jonasongg
Copy link
Contributor

(cherry picked from commit 76a9425)

Fixes #2181

Proposed commit message

Fix lint warnings

Currently, there are various lint warnings that appear when building.

This can cause confusion on what lint problem exactly is causing a
build to fail. Let's fix them.

Other information

@jonasongg
fix lint
a6b1e3e 
(cherry picked from commit 76a9425)
@jonasongg jonasongg requested a review from a team April 1, 2024 07:50
@sopa301
Copy link
Contributor

sopa301 commented Apr 1, 2024

Is it possible to also fix the multiple tags warning in summary charts as well?

@jonasongg
Copy link
Contributor Author

@sopa301 which warnings are you referring to ?

@sopa301
Copy link
Contributor

sopa301 commented Apr 5, 2024

These:
image

@jonasongg
Copy link
Contributor Author

@sopa301 ah ok, just fixed as well!

sopa301
sopa301 approved these changes Apr 6, 2024
View reviewed changes
Copy link
Contributor

@sopa301 sopa301 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sopa301 sopa301 requested a review from a team April 6, 2024 11:52
MarcusTXK
MarcusTXK approved these changes Apr 6, 2024
View reviewed changes
Copy link
Member

@MarcusTXK MarcusTXK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MarcusTXK MarcusTXK requested a review from a team April 6, 2024 12:31
@jonasongg jonasongg mentioned this pull request Apr 6, 2024
Merged
ckcherry23
ckcherry23 approved these changes Apr 13, 2024
View reviewed changes
Copy link
Member

@ckcherry23 ckcherry23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ckcherry23 ckcherry23 merged commit 1e76355 into master Apr 18, 2024
15 checks passed
@github-actions GitHub Actions
Copy link
Contributor

The following links are for previewing this pull request:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sopa301 sopa301 sopa301 approved these changes

@ckcherry23 ckcherry23 ckcherry23 approved these changes

@MarcusTXK MarcusTXK MarcusTXK approved these changes

Assignees
No one assigned
Labels
s.ToMerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix lint warnings
4 participants
@jonasongg @sopa301 @MarcusTXK @ckcherry23