-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#2151] Update Typescript-related Major Dependencies #2166
Changes from 12 commits
7f6656c
c56a6e4
c75e41c
c4f0fd6
d6f241f
b7abe3c
13d9ffe
310b396
9eb87d3
67780a0
88bf41a
f644dc5
160442a
381885c
bd6c08d
2981a81
10beff7
621bc03
a2ff82f
87100c4
ce87923
b1e338d
fd37643
ac925a0
7ab8490
7756234
08b6d3a
a6002c6
5775155
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,7 +6,11 @@ | |
"airbnb-base", | ||
"plugin:vue/recommended", | ||
"@vue/typescript", | ||
"plugin:import/typescript" | ||
"plugin:import/typescript", | ||
"plugin:@stylistic/disable-legacy" | ||
], | ||
"plugins": [ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Enable removed rules. |
||
"@stylistic" | ||
], | ||
"rules": { | ||
"vue/component-definition-name-casing": [ | ||
|
@@ -15,11 +19,11 @@ | |
], | ||
"vue/require-prop-types": 0, | ||
"no-param-reassign": 0, | ||
"arrow-parens": [ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Added namespace. |
||
"@stylistic/arrow-parens": [ | ||
"error", | ||
"always" | ||
], | ||
"indent": [ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Added namespace. |
||
"@stylistic/indent": [ | ||
"error", | ||
2, | ||
{ | ||
|
@@ -34,15 +38,13 @@ | |
"as-needed" | ||
], | ||
"no-alert": 0, | ||
"linebreak-style": 0, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Any reason this was removed? |
||
"max-len": [ | ||
"@stylistic/max-len": [ | ||
"error", | ||
{ | ||
"code": 120 | ||
} | ||
], | ||
"prefer-object-spread": 0, | ||
"function-call-argument-newline": 0, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same for this? Maybe good to give a one-line reason for everything removed or newly added |
||
"vue/no-computed-properties-in-data": 0, | ||
"import/extensions": [ | ||
"error", | ||
|
@@ -60,14 +62,13 @@ | |
"files": ["*.ts"], | ||
"extends": [ | ||
"airbnb-typescript/base", | ||
"plugin:@typescript-eslint/recommended" | ||
"plugin:@stylistic/disable-legacy" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
], | ||
"parserOptions": { | ||
"project": ["./tsconfig.json"] | ||
}, | ||
"rules": { | ||
"indent": "off", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Removed with the addition of |
||
"@typescript-eslint/indent": [ | ||
"@stylistic/indent": [ | ||
"error", | ||
2, | ||
{ | ||
|
@@ -77,8 +78,8 @@ | |
"SwitchCase": 0 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
} | ||
], | ||
"@typescript-eslint/member-delimiter-style": "error", | ||
"@typescript-eslint/type-annotation-spacing": "error", | ||
"@stylistic/member-delimiter-style": "error", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Changed namespace as part of the rules migration. |
||
"@stylistic/type-annotation-spacing": "error", | ||
"@typescript-eslint/array-type": [ | ||
"error", | ||
{ | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stylistic/disable-legacy
added to remove old default behaviour that caused bugs and had to be manually turned off.