Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2151] Update Typescript-related Major Dependencies #2166

Merged
merged 29 commits into from
Apr 27, 2024
Merged

[#2151] Update Typescript-related Major Dependencies #2166

Show file tree
Hide file tree
Changes from 20 commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
7f6656c
Temp commit
sopa301 Mar 11, 2024
c56a6e4
Merge branch 'master' of https://github.com/sopa301/RepoSense into 21…
sopa301 Mar 20, 2024
c75e41c
Update eslint
sopa301 Mar 20, 2024
c4f0fd6
Fix style
sopa301 Mar 20, 2024
d6f241f
Revert typescript 5.0
sopa301 Mar 20, 2024
b7abe3c
Fix bug
sopa301 Mar 20, 2024
13d9ffe
Clean up rules
sopa301 Mar 20, 2024
310b396
Add namespace to rule
sopa301 Mar 20, 2024
9eb87d3
Remove disabler for removed default rule
sopa301 Mar 20, 2024
67780a0
Remove useless rule
sopa301 Mar 20, 2024
88bf41a
Merge branch 'master' of https://github.com/sopa301/RepoSense into 21…
sopa301 Mar 28, 2024
f644dc5
Merge branch 'master' of https://github.com/reposense/RepoSense into …
sopa301 Apr 4, 2024
160442a
Remove lint fixes
sopa301 Apr 6, 2024
381885c
Merge branch 'master' into 2151-ts
MarcusTXK Apr 13, 2024
bd6c08d
Re-add disabled rules
sopa301 Apr 13, 2024
2981a81
Merge branch 'master' of https://github.com/reposense/RepoSense into …
sopa301 Apr 13, 2024
10beff7
Merge branch '2151-ts' of https://github.com/sopa301/RepoSense into 2…
sopa301 Apr 13, 2024
621bc03
Move rules for easier review
sopa301 Apr 13, 2024
a2ff82f
Fix style
sopa301 Apr 13, 2024
87100c4
Re-add recommended config
sopa301 Apr 13, 2024
ce87923
Fix type bugs
sopa301 Apr 15, 2024
b1e338d
Merge branch 'master' into 2151-ts
sopa301 Apr 15, 2024
fd37643
Merge branch 'master' of https://github.com/reposense/RepoSense into …
sopa301 Apr 20, 2024
ac925a0
Merge branch 'master' of https://github.com/reposense/RepoSense into …
sopa301 Apr 24, 2024
7ab8490
Fix style
sopa301 Apr 24, 2024
7756234
Merge branch 'master' into 2151-ts
ckcherry23 Apr 27, 2024
08b6d3a
Merge branch 'master' of https://github.com/reposense/RepoSense into …
sopa301 Apr 27, 2024
a6002c6
Merge branch '2151-ts' of https://github.com/sopa301/RepoSense into 2…
sopa301 Apr 27, 2024
5775155
Merge branch 'master' into 2151-ts
sopa301 Apr 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 16 additions & 13 deletions frontend/.eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,11 @@
"airbnb-base",
"plugin:vue/recommended",
"@vue/typescript",
"plugin:import/typescript"
"plugin:import/typescript",
"plugin:@stylistic/disable-legacy"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stylistic/disable-legacy added to remove old default behaviour that caused bugs and had to be manually turned off.

],
"plugins": [
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enable removed rules.

"@stylistic"
],
"rules": {
"vue/component-definition-name-casing": [
Expand All @@ -15,11 +19,11 @@
],
"vue/require-prop-types": 0,
"no-param-reassign": 0,
"arrow-parens": [
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added namespace.

"@stylistic/arrow-parens": [
"error",
"always"
],
"indent": [
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added namespace.

"@stylistic/indent": [
"error",
2,
{
Expand All @@ -34,15 +38,15 @@
"as-needed"
],
"no-alert": 0,
"linebreak-style": 0,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason this was removed?

"max-len": [
"@stylistic/linebreak-style": 0,
Copy link
Contributor Author

@sopa301 sopa301 Apr 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added namespace. Even though linebreak-style is not enabled by default (due to it being from a plugin), the rule has been added for continuity.

"@stylistic/max-len": [
"error",
{
"code": 120
}
],
"prefer-object-spread": 0,
"function-call-argument-newline": 0,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same for this? Maybe good to give a one-line reason for everything removed or newly added

"@stylistic/function-call-argument-newline": 0,
Copy link
Contributor Author

@sopa301 sopa301 Apr 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added namespace. Even though function-call-argument-newline is not enabled by default (due to it being from a plugin), the rule has been added for continuity.

"vue/no-computed-properties-in-data": 0,
"import/extensions": [
"error",
Expand All @@ -60,25 +64,24 @@
"files": ["*.ts"],
"extends": [
"airbnb-typescript/base",
"plugin:@typescript-eslint/recommended"
"plugin:@typescript-eslint/recommended",
"plugin:@stylistic/disable-legacy"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

disable-legacy had to be re-added here to disable typescript-eslint/recommended old linting rules from interfering with the new linting rules.

],
"parserOptions": {
"project": ["./tsconfig.json"]
},
"rules": {
"indent": "off",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed with the addition of @stylistic/disable-legacy

"@typescript-eslint/indent": [
"@stylistic/indent": [
"error",
2,
{
"ignoredNodes": [
"ConditionalExpression"
],
"SwitchCase": 0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SwitchCase is 0 by default.

]
}
],
"@typescript-eslint/member-delimiter-style": "error",
"@typescript-eslint/type-annotation-spacing": "error",
"@stylistic/member-delimiter-style": "error",
Copy link
Contributor Author

@sopa301 sopa301 Apr 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed namespace as part of the rules migration.

"@stylistic/type-annotation-spacing": "error",
"@typescript-eslint/array-type": [
"error",
{
Expand Down
Loading
Loading