Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2001] Extract c-zoom-commit-message component from views/c-zoom #2132

Merged
merged 15 commits into from
Mar 27, 2024

Conversation

sopa301
Copy link
Contributor

@sopa301 sopa301 commented Feb 20, 2024

Part of #2001.

Proposed commit message

Many of the frontend files are difficult to navigate through due to the
large file sizes. As we add more features to the frontend, it is
getting harder to maintain. This is also very unfriendly towards new
contributors. 

Let us break down frontend files in a logical manner, continuing with
extracting c-zoom-commit-message from views/c-zoom.

Other information

@sopa301 sopa301 removed the s.Ongoing label Feb 20, 2024
@ckcherry23 ckcherry23 requested a review from a team February 21, 2024 08:26
@ckcherry23 ckcherry23 marked this pull request as ready for review February 21, 2024 08:26
Copy link
Member

@ckcherry23 ckcherry23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I just have one comment about a possibly unnecessary prop.

frontend/src/components/c-zoom-commit-message.vue Outdated Show resolved Hide resolved
Copy link
Member

@ckcherry23 ckcherry23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for helping with the componentization.

Copy link
Member

@MarcusTXK MarcusTXK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, nice job with this, it makes c-zoom.vue alot easier to read. I have just a minor nitpick with the spacing of the methods, as some have an extra new lines after them and others do not.

Shall we standardize it as no spaces between the methods?

@sopa301
Copy link
Contributor Author

sopa301 commented Mar 20, 2024

Okay, should we add a linting rule for that?

@sopa301 sopa301 requested a review from MarcusTXK March 20, 2024 13:09
@MarcusTXK
Copy link
Member

Okay, should we add a linting rule for that?

Yup sure, feel free to create an issue for this, I think that will definitely help with consistency

Copy link
Member

@MarcusTXK MarcusTXK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ckcherry23 ckcherry23 merged commit ffa9a72 into reposense:master Mar 27, 2024
10 checks passed
Copy link
Contributor

The following links are for previewing this pull request:

georgetayqy added a commit that referenced this pull request Apr 4, 2024
* [#2120] Update RepoSense contributors in documentation (#2138)

The current About page on the RepoSense docs does not reflect the
updated list of developers working on RepoSense.

Let's move to update the list to more accurately reference the current
developers of RepoSense.

* [#2001] Extract c-zoom-commit-message component from views/c-zoom (#2132)

Many of the frontend files are difficult to navigate through due to the
large file sizes. As we add more features to the frontend, it is
getting harder to maintain. This is also very unfriendly towards new
contributors. 

Let us break down frontend files in a logical manner, continuing with
extracting c-zoom-commit-message from views/c-zoom.

* [#2142] Fix Vulnerabilities (#2143)

Fix vulnerabilities in codebase.

There are existing vulnerabilities in the codebase.

Let's fix as many as possible.

* Bump follow-redirects from 1.15.4 to 1.15.6 in /frontend (#2160)

Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.4 to 1.15.6.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](follow-redirects/follow-redirects@v1.15.4...v1.15.6)

* Bump webpack-dev-middleware from 5.3.3 to 5.3.4 in /frontend (#2168)

Bumps [webpack-dev-middleware](https://github.com/webpack/webpack-dev-middleware) from 5.3.3 to 5.3.4.
- [Release notes](https://github.com/webpack/webpack-dev-middleware/releases)
- [Changelog](https://github.com/webpack/webpack-dev-middleware/blob/v5.3.4/CHANGELOG.md)
- [Commits](webpack/webpack-dev-middleware@v5.3.3...v5.3.4)

* [#2151] Update LoadingOverlay and Minor Versions of Node Dependencies (#2152)

Update LoadingOverlay and Minor Versions of Node Dependencies

Some dependencies are not at their latest minor or patch releases.

Let's update these dependencies, as well as LoadingOverlay as part of a
bug fix.

* Factor out markdown parser

* [#2109] Add search by tag functionality (#2167)

Add search by tag functionality

It can be useful to search author/repos by git tags.

Let's add this functionality to make it easier to filter by tags. This
commit also fixes a bug that existed in a previous version of the
feature which resulted in all users being shown to belong to same group.

* Refactor chunks

* Fix style

* Add parts of blurb

* Fix linting

* Fix style

* Fix missing html parsing

* Remove unused import

---------

Co-authored-by: George Tay <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: jonasongg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants