Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#2123] Fix zoom bug if zUser is undefined #2126

Merged
merged 6 commits into from
Mar 16, 2024
Merged

[#2123] Fix zoom bug if zUser is undefined #2126

merged 6 commits into from
Mar 16, 2024

Conversation

jonasongg
Copy link
Contributor

Fixes #2123

Proposed commit message

Fix error thrown when zUser is undefined

Currently, an error is thrown when zUser is defined in c-zoom.vue. This
might be caused by zFilterSearch containing a query that returns no
results. Though this happening through normal user interaction is rare
(editing URL, for example), RepoSense should handle this case
gracefully rather than throwing an error.

Let's fix this bug by resetting the zoom view if the error happens.

Other information

@jonasongg jonasongg requested a review from a team February 19, 2024 05:45
@jonasongg jonasongg changed the title Fix zoom bug if zUser is undefined [#2123] Fix zoom bug if zUser is undefined Feb 19, 2024
sopa301
sopa301 approved these changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@sopa301 sopa301 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sopa301 sopa301 requested a review from a team March 4, 2024 04:30
vvidday
vvidday reviewed Mar 11, 2024
View reviewed changes
Copy link
Contributor

@vvidday vvidday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job catching the bug & thanks for the fix! Have a minor comment about the use of !:

frontend/src/views/c-zoom.vue Outdated Show resolved Hide resolved
@vvidday vvidday self-requested a review March 14, 2024 12:12
vvidday
vvidday approved these changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@vvidday vvidday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@vvidday vvidday requested a review from a team March 14, 2024 12:13
ckcherry23
ckcherry23 approved these changes Mar 14, 2024
View reviewed changes
Copy link
Member

@ckcherry23 ckcherry23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch and thanks for the bug fix!

@ckcherry23 ckcherry23 merged commit 22992cb into reposense:master Mar 16, 2024
10 checks passed
@github-actions GitHub Actions
Copy link
Contributor

The following links are for previewing this pull request:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sopa301 sopa301 sopa301 approved these changes

@ckcherry23 ckcherry23 ckcherry23 approved these changes

@vvidday vvidday vvidday approved these changes

Assignees
No one assigned
Labels
s.ToMerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeError when visiting a certain URL
5 participants
@jonasongg @vvidday @ckcherry23 @sopa301 @gok99