Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#1933] Fix broken DevOps Guide link in Learning Basics #2107

Merged
merged 2 commits into from
Feb 11, 2024
Merged

[#1933] Fix broken DevOps Guide link in Learning Basics #2107

merged 2 commits into from
Feb 11, 2024

Conversation

supermii2
Copy link
Contributor

@supermii2 supermii2 commented Feb 2, 2024 •
edited by ckcherry23
Loading

Fixes #1933

Fix broken link to DevOps Guide in Learning Basics page.

Under the DevOps section in the developer guide,
the link to DevOps guide leads a Wiki link instead of redirecting to
the DevOps guide on the actual Reposense website.

Let's fix the broken link by changing the address to the correct page.

@supermii2 supermii2 changed the title Fix broken DevOps Guide link in Learning Basics [#1933] Fix broken DevOps Guide link in Learning Basics Feb 2, 2024
ckcherry23
ckcherry23 approved these changes Feb 2, 2024
View reviewed changes
Copy link
Member

@ckcherry23 ckcherry23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ckcherry23 ckcherry23 requested review from a team February 2, 2024 17:06
sopa301
sopa301 approved these changes Feb 3, 2024
View reviewed changes
Copy link
Contributor

@sopa301 sopa301 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

gok99
gok99 approved these changes Feb 3, 2024
View reviewed changes
Copy link
Contributor

@gok99 gok99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gok99 gok99 added s.ToMerge and removed s.ToReview labels Feb 3, 2024
@ckcherry23
Copy link
Member

Hi @supermii2, can you format your commit message body according to these guidelines?
https://se-education.org/guides/conventions/git.html#commit-message-body

Specifically, wrap the message body at 72 characters. You can utilise online tools for this.

@supermii2
Copy link
Contributor Author

Fixed! Thank you for pointing this out

@ckcherry23 ckcherry23 merged commit 945405a into reposense:master Feb 11, 2024
10 checks passed
@github-actions GitHub Actions
Copy link
Contributor

The following links are for previewing this pull request:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sopa301 sopa301 sopa301 approved these changes

@ckcherry23 ckcherry23 ckcherry23 approved these changes

@gok99 gok99 gok99 approved these changes

Assignees
No one assigned
Labels
s.ToMerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Link to DevOps guide is broken
4 participants
@supermii2 @ckcherry23 @gok99 @sopa301