Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2098] Add show more button for error messages #2105

Merged
merged 13 commits into from
Mar 14, 2024
Merged

[#2098] Add show more button for error messages #2105

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
9447d4b
Add show more button for error messages
jonasongg Jan 30, 2024
deeb9da
Merge remote-tracking branch 'upstream/master' into fix-long-error-me…
jonasongg Feb 2, 2024
a727aeb
Fix lint errors
jonasongg Feb 2, 2024
8292a05
Add changes to show more button
jonasongg Feb 5, 2024
ea57328
Add tests for show more button
jonasongg Feb 15, 2024
813e4a4
Add newline for repo-config.csv
jonasongg Feb 15, 2024
9b79355
Merge remote-tracking branch 'upstream/master' into fix-long-error-me…
jonasongg Feb 15, 2024
18ff524
Merge branch 'master' into fix-long-error-message
ckcherry23 Feb 17, 2024
483d01d
Change title of error message show more test
jonasongg Feb 17, 2024
0a32fbe
Add numberOfErrorMessagesToShow variable
jonasongg Feb 17, 2024
6ccb766
Merge branch 'master' into fix-long-error-message
vvidday Feb 19, 2024
aeb7595
Merge remote-tracking branch 'upstream/master' into fix-long-error-me…
jonasongg Mar 4, 2024
3ba331e
Fix tests due to error messages box
jonasongg Mar 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions frontend/src/styles/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,20 @@ header {
}
}

&__show-more-container {
display: flex;
justify-content: center;
margin: .5rem 0 .3rem 0;
}

&__show-more {
border: 1.5px solid mui-color('red', '900');
border-radius: 8px;
color: mui-color('red', '900');
font-weight: bold;
padding: .4rem .5rem;
}

jonasongg marked this conversation as resolved.
Show resolved Hide resolved
&__message {
border-bottom: .1rem solid;
font-weight: bolder;
Expand Down
14 changes: 12 additions & 2 deletions frontend/src/views/c-summary.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,9 @@
.error-message-box(v-if="Object.entries(errorMessages).length && !isWidgetMode")
.error-message-box__close-button(v-on:click="dismissTab($event)") ×
.error-message-box__message The following issues occurred when analyzing the following repositories:
.error-message-box__failed-repo(v-for="errorBlock in errorMessages")
.error-message-box__failed-repo(
v-for="errorBlock in errorIsShowingMore ? errorMessages : Object.values(errorMessages).slice(0, 4)"
)
font-awesome-icon(icon="exclamation")
span.error-message-box__failed-repo--name {{ errorBlock.repoName }}
.error-message-box__failed-repo--reason(
Expand All @@ -92,7 +94,10 @@
v-bind:href="getReportIssueEmailLink(errorBlock.errorMessage)"
)
span {{ getReportIssueEmailAddress() }}
.error-message-box__failed-repo--reason(v-else) {{ errorBlock.errorMessage }}
.error-message-box__failed-repo--reason(v-else) {{ errorBlock.errorMessage }}\
.error-message-box__show-more-container(v-if="Object.keys(errorMessages).length >= 4")
jonasongg marked this conversation as resolved.
Show resolved Hide resolved
a.error-message-box__show-more(v-if="!errorIsShowingMore" v-on:click="toggleErrorShowMore()") SHOW MORE...
a.error-message-box__show-more(v-else v-on:click="toggleErrorShowMore()") SHOW LESS...
jonasongg marked this conversation as resolved.
Show resolved Hide resolved
.fileTypes(v-if="filterBreakdown && !isWidgetMode")
.checkboxes.mui-form--inline(v-if="Object.keys(fileTypeColors).length > 0")
label(style='background-color: #000000; color: #ffffff')
Expand Down Expand Up @@ -201,6 +206,7 @@ export default defineComponent({
filterGroupSelectionWatcherFlag: false,
chartGroupIndex: undefined as number | undefined,
chartIndex: undefined as number | undefined,
errorIsShowingMore: false,
};
},
computed: {
Expand Down Expand Up @@ -933,6 +939,10 @@ export default defineComponent({
getFontColor(color: string) {
return window.getFontColor(color);
},

toggleErrorShowMore() {
this.errorIsShowingMore = !this.errorIsShowingMore;
},
},
});
</script>
Expand Down
Loading