Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2073] Refactor RepoConfigCsvParser::processLine method to avoid arrowhead style code #2080

Merged
merged 3 commits into from
Jan 18, 2024

Conversation

georgetayqy
Copy link
Contributor

Fixes #2073

Proposed commit message

The current implementation of `RepoConfigCsvParser::processLine`
contains code that has 3 levels of indentation, making it 
difficult to read and maintain.

With the proposed changes, the level of deep nesting has 
been reduced to 2 levels, making the code more 
readable and maintainable.

Let's move to refactor and clean up the code to avoid 
arrowhead-style codes for better readability and 
maintainability.

Other information

NA

@ckcherry23 ckcherry23 requested a review from a team January 12, 2024 21:41
Copy link
Contributor

@gok99 gok99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pretty straight-forward refactor!

Copy link
Member

@ckcherry23 ckcherry23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@MarcusTXK MarcusTXK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice job reducing the nested if blocks.

Just a minor feedback on the commit message body. The wrap is at 72 characters, so you could do it as such to reduce the number of lines:

The current implementation of `RepoConfigCsvParser::processLine` 
contains code that has 3 levels of indentation, making it difficult to 
read and maintain. 

With the proposed changes, the level of deep nesting has been reduced 
to 2 levels, making the code more readable and maintainable. 

Let's move to refactor and clean up the code to avoid arrowhead-style 
codes for better readability and maintainability.

@georgetayqy
Copy link
Contributor Author

@MarcusTXK Thank you for the advice, I will keep that in mind in my future PRs!

@chan-j-d chan-j-d merged commit 4ef7210 into reposense:master Jan 18, 2024
9 of 10 checks passed
Copy link
Contributor

The following links are for previewing this pull request:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor RepoConfigCsvParser::processLine method to avoid arrowhead style code
5 participants