-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#2076] Refactor RepoConfiguration to simplify constructor complexity #2078
Merged
ckcherry23
merged 13 commits into
reposense:master
from
georgetayqy:enhancement-repoconfig-builder-pattern
Feb 16, 2024
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
7c321de
Refactor RepoConfiguration to obey Builder Pattern
georgetayqy 6228ec8
Merge branch 'master' into enhancement-repoconfig-builder-pattern
gok99 be1ef45
Merge branch 'master' into enhancement-repoconfig-builder-pattern
ckcherry23 ae80634
Fix bugs and implement new unit test cases
georgetayqy a50e488
Merge branch 'master' into enhancement-repoconfig-builder-pattern
gok99 052050b
Refactor RepoBuilder into Builder
georgetayqy d58ccee
Combine processOrganization with processNames
georgetayqy 4b5cf86
Remove redundant copy constructor
georgetayqy 749f005
Merge branch 'master' into enhancement-repoconfig-builder-pattern
MarcusTXK 237f8d7
Add new unit tests and remove print statements
georgetayqy 2e8cc4c
Merge branch 'enhancement-repoconfig-builder-pattern' of https://gith…
georgetayqy 53d8a3e
Merge branch 'master' into enhancement-repoconfig-builder-pattern
gok99 0e9e213
Merge branch 'master' into enhancement-repoconfig-builder-pattern
ckcherry23 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
8 changes: 8 additions & 0 deletions
8
src/main/java/reposense/parser/ConfigurationBuildException.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
package reposense.parser; | ||
|
||
/** | ||
* Signals that there was an issue building a Configuration (missing parameters, etc.). | ||
*/ | ||
public class ConfigurationBuildException extends RuntimeException { | ||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For lines 38 - 39,
new ArrayList<>()
Initializer forignoreGlobList
andignoredAuthorsList
is now redundant