Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2054] Fix zoom view bug #2055

Merged
merged 16 commits into from
Oct 28, 2023
+9 −2
Merged

[#2054] Fix zoom view bug #2055

Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
57de7d2
Migrate c-ramp.vue to typescript
jq1836 Sep 23, 2023
b12873c
Fix ramp slice position bug
jq1836 Sep 23, 2023
06935b0
Add null to signature of getContributionMessage
jq1836 Sep 23, 2023
844bf8e
Typecast daily commits
jq1836 Sep 23, 2023
afb844c
Remove added whitespace
jq1836 Sep 23, 2023
e3f02b0
Fix comment
jq1836 Sep 25, 2023
9856fea
Split getContributionMessage method
jq1836 Sep 25, 2023
0e8fe53
Fix merge conflict
jq1836 Sep 25, 2023
a5a0998
Remove misleading comment
jq1836 Sep 25, 2023
3333b88
Make cast safe
jq1836 Sep 30, 2023
55551fb
Merge branch 'master' into 1936-migrate-c-ramp
ckcherry23 Oct 2, 2023
6296790
Merge branch 'master' into 1936-migrate-c-ramp
jq1836 Oct 4, 2023
03f7d90
Revert back to unsafe type cast
jq1836 Oct 8, 2023
901befc
Merge branch 'master' into 1936-migrate-c-ramp
jq1836 Oct 8, 2023
e50c6c9
Fix zoom view bug
jq1836 Oct 8, 2023
abbd144
Merge branch 'master' into 2054-fix-zoom-view-bug
jq1836 Oct 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions frontend/src/components/c-ramp.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,8 +142,15 @@ export default defineComponent({
}

const zoomUser = { ...user };
// Type cast here is unsafe
zoomUser.commits = user.dailyCommits as Commit[];
// Calculate total commit result insertion and deletion for the daily/weekly commit selected
zoomUser.commits = user.dailyCommits.map(
(dailyCommit) => ({
insertions: dailyCommit.commitResults.reduce((acc, currCommitResult) => acc + currCommitResult.insertions, 0),
deletions: dailyCommit.commitResults.reduce((acc, currCommitResult) => acc + currCommitResult.deletions, 0),
...dailyCommit,
commitResults: dailyCommit.commitResults.map((commitResult) => ({ ...commitResult, isOpen: true })),
}),
) as Commit[];

const info = {
zRepo: user.repoName,
Expand Down
Loading