-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#1986] Add cypress tests for renderFilterHash #2017
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking this up @nseah21 and sorry for the late review.
I think the test cases you have added now seem pretty comprehensive.
However, we may want to wait until issue #2016 is fixed before adding a test case for that scenario within this PR. This same issue is also apparent during the test case 'checked file types: url params should persist after change and reload'
as the yml
option gets unchecked by itself after reload.
Hi, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, merging this in so that more tests can be added in #2086.
The following links are for previewing this pull request:
|
Fixes #1986
Add cypress tests for renderFilterHash
Other information
NA