-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#1994] Migrate build.gradle from Groovy to Kotlin #2008
Conversation
When running Could I kindly request for some guidance on how to resolve the following issue?
|
I ran the changes in your PR with the
This might be a good starting point. Seems like the arguments were not passed into npm directly but rather through |
@sikai00 Thank you for pointing me in the right direction. I have re-attempted the migration and have gotten most of the tasks to run successfully. However, the task
instead of:
when building with the original Has anyone experienced this issue previously when writing the |
Changes are looking good so far! Don't forget the newline at EOF so that the CI tests can run. |
Bumping the failing build: |
…nto migrate-build-gradle
@nseah21 Have you tried running The additional logging info might help in determining the exact cause behind |
build.gradle.kts
Outdated
tasks.register<JacocoReport>("coverage") | ||
|
||
tasks.named<JacocoReport>("coverage").configure { | ||
dependsOn(systemtest, frontendTest) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Task dependency should not be introduced here
Hi, |
Per the error message,
it seems the fix to your issue is to declare an explicit dependency for the predefined task 'test'. This follows from coverage using 'test' to know the amount of coverage. As for the second issue, I did some Googling online. Perhaps this may help? Hope this helps you fix the issues you are facing! |
Hi @nseah21, just bumping this PR to check its progress. Could I check if there are any major blockers for you currently? |
Hi @MarcusTXK, I am still trying to troubleshoot an issue with reading the execution data file.
I have attempted the fix posted by @sikai00 above but the build is still throwing the error. May I request for some guidance on this issue? Thank you. |
@nseah21 I'm not sure if we want to merge this PR in the end, as I mentioned in #1994 (comment) |
Hi, |
@gok99 @yhtMinceraft1010X This pull request is ready for the next round of reviews. |
The following links are for previewing this pull request:
|
Fixes #1994
Migrate build.gradle from Groovy to Kotlin
Other information
It is worth noting that builds using Kotlin tend to be slower than builds using Groovy.
However, it is assumed that the added benefit of a more standardised syntax (as mentioned in #1994) outweighs this performance tradeoff.