Skip to content

Commit

Permalink
Align right panel with welcome title (#2229)
Browse files Browse the repository at this point in the history
Align panel titles

The title text on the left panel is not flushed to the top because it
is a header.

There are several types of title texts on the right panel. Initially,
some were headers and others were not. There was padding to ensure that
those which were not headers were not flushed to the top.  However, this
meant that those headers were lower than expected and not aligned. 

To align the texts, let us remove the padding for the right panel and
set the first element on the right panel as a header.
  • Loading branch information
jedkohjk authored Jul 24, 2024
1 parent 90533da commit dd0c13e
Show file tree
Hide file tree
Showing 3 changed files with 22 additions and 20 deletions.
2 changes: 1 addition & 1 deletion frontend/src/styles/panels.scss
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
@import 'z-indices';

.panel-padding {
padding: 2rem 1.5rem 2rem 2.2rem;
padding: 0 1.5rem 2rem 2.2rem;
}

#app-wrapper {
Expand Down
17 changes: 9 additions & 8 deletions frontend/src/views/c-authorship.vue
Original file line number Diff line number Diff line change
@@ -1,13 +1,14 @@
<template lang="pug">
#authorship
.panel-title
span Code Panel
.toolbar--multiline
a(
v-if="activeFilesCount < selectedFiles.length",
v-on:click="toggleAllFileActiveProperty(true)"
) show all file details
a(v-if="activeFilesCount > 0", v-on:click="toggleAllFileActiveProperty(false)") hide all file details
h2
.panel-title
span Code Panel
.toolbar--multiline
a(
v-if="activeFilesCount < selectedFiles.length",
v-on:click="toggleAllFileActiveProperty(true)"
) show all file details
a(v-if="activeFilesCount > 0", v-on:click="toggleAllFileActiveProperty(false)") hide all file details
.panel-heading
a.group-name(
v-bind:href="info.location", target="_blank",
Expand Down
23 changes: 12 additions & 11 deletions frontend/src/views/c-zoom.vue
Original file line number Diff line number Diff line change
@@ -1,16 +1,17 @@
<template lang="pug">
#zoom(v-if="filteredUser")
.panel-title
span Commits Panel
.toolbar--multiline(v-if="filteredUser.commits.length && totalCommitMessageBodyCount")
a(
v-if="expandedCommitMessagesCount < totalCommitMessageBodyCount",
v-on:click="toggleAllCommitMessagesBody(true); toggleDiffstatView(true);"
) show all commit details
a(
v-if="expandedCommitMessagesCount > 0",
v-on:click="toggleAllCommitMessagesBody(false); toggleDiffstatView(false);"
) hide all commit details
h2
.panel-title
span Commits Panel
.toolbar--multiline(v-if="filteredUser.commits.length && totalCommitMessageBodyCount")
a(
v-if="expandedCommitMessagesCount < totalCommitMessageBodyCount",
v-on:click="toggleAllCommitMessagesBody(true); toggleDiffstatView(true);"
) show all commit details
a(
v-if="expandedCommitMessagesCount > 0",
v-on:click="toggleAllCommitMessagesBody(false); toggleDiffstatView(false);"
) hide all commit details
.panel-heading
.group-name
span(
Expand Down

0 comments on commit dd0c13e

Please sign in to comment.