Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disabling plugin #149

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

thomaswinkler
Copy link
Contributor

When using custom commands, it is not enough to just remove registerReportPortalPlugin(on, config) from Cypress configuration as tasks will not be registered. We also use different cypress configs, for example one for local development and one for ci integration. There has to be a way to configure the tasks without the tests to break.

Introduced disableReportPortalPlugin(on) that simply creates no-op tasks for all custom commands.

@thomaswinkler
Copy link
Contributor Author

Pushed an improved implementation that does now do some simple validation of config.reporterOptions and disables the plugin in index.js and cypressReporter. In case of an error it logs a message like Report Portal plugin disabled. Error: Missing required config option. Required options: token,endpoint,launch,project.

Implementation could be extended to provide users feedback on wrong endpoints, etc.

@thomaswinkler
Copy link
Contributor Author

Current implementation does not work for cypress-multi-reporter. Needs some refactoring of utils.getConfig().

* develop:
  5.1.1 -> 5.1.2-SNAPSHOT
  Mention 5.1.1 version in changelog file
  5.1.1
  Update VERSION file with 5.1.1
  Update changelog
  EPMRPP-81509 || Add mergeOptions config
  Fix passing mode property from config options (reportportal#142)
  Finish skipped tests (reportportal#141)
  Bump decode-uri-component from 0.2.0 to 0.2.2 (reportportal#136)
  Bump minimatch from 3.0.4 to 3.0.5 (reportportal#143)
  Bump qs from 6.5.2 to 6.5.3 (reportportal#137)
  Use patch version fragment
  5.1.0 -> 5.1.1-SNAPSHOT
@thomaswinkler
Copy link
Contributor Author

Added support for cypress-multi-reporter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant