adding error router to rescue in event processing #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
repeatedly
reviewed
Nov 15, 2018
| @@ -126,6 +126,7 @@ def run | |||
| rescue => e | |||
| log.error "unexpected error", :error => e.to_s | |||
| log.error_backtrace | |||
| router.emit_error_event(tag, time, record, e) | |||
There was a problem hiding this comment.
record may be nil when user doesn't specify parser. Need to check record / map value.
In addition, need option to emit error event because emit event in this point is sometimes not useful, e.g. hard to recover broken value.
There was a problem hiding this comment.
What would we be checking or comparing the record/map value to? Could you give me a quick example of how we could check this accurately?
You make a good point about the config option and not always emitting errors. I'll see if I can add that code for the config quickly.
Thanks for your feedback!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
According to the docs, we should be emitting routing errors via
emit_error_event. I've noticed that once FluentD hits an error, it doesn't ship it to the output, and it fails to recover.However when I modify the plugin to contain this line, it emits the error properly and continues past the error.
Could you please let me know if this is a good or bad idea?
Thank you,