Rocky/web wallet #774
Draft
Rocky/web wallet #774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
12 Skipped Deployments
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+101
to
+105
| accounts: namespaceToUpdate.accounts.concat( | ||
| `${namespaceToUpdate.chains?.[0]}:${baseAddress}${Math.floor( | ||
| Math.random() * (9 - 1 + 1) + 0 | ||
| )}` | ||
| ) // generates random number between 0 and 9 |
Check failure
Code scanning / CodeQL
Insecure randomness High
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix AI 11 days ago
To fix the problem, we need to replace the use of Math.random() with a cryptographically secure random number generator. In the browser environment, we can use window.crypto.getRandomValues to generate a secure random number. This change will ensure that the generated account addresses are not predictable and thus more secure.
Suggested changeset
1
advanced/wallets/reown-web-wallet/src/pages/session.tsx
| @@ -102,3 +102,3 @@ | ||
| `${namespaceToUpdate.chains?.[0]}:${baseAddress}${Math.floor( | ||
| Math.random() * (9 - 1 + 1) + 0 | ||
| window.crypto.getRandomValues(new Uint32Array(1))[0] / (0xFFFFFFFF + 1) * (9 - 1 + 1) + 0 | ||
| )}` |
Copilot is powered by AI and may make mistakes. Always verify output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.