Skip to content
This repository has been archived by the owner on Aug 10, 2024. It is now read-only.

Support ox and clean fxmanifest #170

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

matahombres
Copy link

No description provided.

fxmanifest.lua Outdated
server_scripts {
'@mysql-async/lib/MySQL.lua', -- uncomment if ghmatti and oxmysql
--'@mysql-async/lib/MySQL.lua', -- uncomment if ghmatti and oxmysql
'@oxmysql/lib/MySQL.lua'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without a comma at the end of this line, this fxmanifest file is broken and the resource simply won't load.

Copy link
Author

@matahombres matahombres Jan 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read it correctly. have comma before the comment

Also tell you that actually oxmysql has support for mysql-assync (This is achieved with the "provider").
Let's say it's like an alias

In fact, I would say that you are the one who has not put the comma.
'@oxmysql/lib/MySQL.lua' It is a line that is not in the file

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is in the middle of a list.
'config.lua', comes immediately after this line, and without a comma it will be ignored by lua.
The syntax is simply invalid.

I don't know why you think the line isn't in the file, click "Files Changed" at the top of the PR and scroll down to this comment. It's there. You added it. This breaks the PR.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I'm dumb because I was looking at renzuzu:main's code.
Change and thx

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants