Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subItemDisplayKey as it's own prop #79

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

var
Copy link

@var var commented Dec 5, 2018

Often times, the displayKey for item and subitem might not be the same and having them as same is causing issues of not displaying the the item and subitem appropriately.

@renrizzolo
Copy link
Owner

great!
I think this should fall back to the displayKey prop when subItemDisplayKey isn't present though.

@var
Copy link
Author

var commented Dec 7, 2018

updated.

@var
Copy link
Author

var commented Jan 12, 2019

Hey @renrizzolo got a chance to look at this?

@renrizzolo
Copy link
Owner

ah sorry, I did.
There are a few things that would break in its current state.
displayKey is used for finding the items (and sub items) when displaying the selected items (chips), for example. Same for the filtering (search) function.
It's fixable but felt a little hacky.

@github-actions
Copy link

This PR is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added the Stale label Feb 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants